chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_apitest.cc ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

index 952a0fdf5369b9c4b74ae495fe3d099fece66d30..934bcd84a95c86bd43471d2425941dc5391f6ac4 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

@@ -47,8 +47,7 @@ class ChromeRuntimeAPIDelegate : public extensions::RuntimeAPIDelegate,

bool CheckForUpdates(const std::string& extension_id,

const UpdateCheckCallback& callback) override;

void OpenURL(const GURL& uninstall_url) override;

- bool GetPlatformInfo(

- extensions::core_api::runtime::PlatformInfo* info) override;

+ bool GetPlatformInfo(extensions::api::runtime::PlatformInfo* info) override;

bool RestartDevice(std::string* error_message) override;

bool OpenOptionsPage(const extensions::Extension* extension) override;