chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

index 97ed00817dc274701596cae6f83b978832f4638c..eb7ff39c4c9aa53a8c90444cda2293dbdeb056a3 100644

--- a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

@@ -51,8 +51,8 @@ TEST_F(DeclarativeChromeContentRulesRegistryTest, ActiveRulesDoesntGrow) {

EXPECT_EQ(0u, registry->GetActiveRulesCountForTesting());

// Add a rule.

- linked_ptr<core_api::events::Rule> rule(new core_api::events::Rule);

- core_api::events::Rule::Populate(

+ linked_ptr<api::events::Rule> rule(new api::events::Rule);

+ api::events::Rule::Populate(

*base::test::ParseJson(

"{\n"

" \"id\": \"rule1\",\n"

@@ -67,7 +67,7 @@ TEST_F(DeclarativeChromeContentRulesRegistryTest, ActiveRulesDoesntGrow) {

" ]\n"

"}"),

rule.get());

- std::vector<linked_ptr<core_api::events::Rule>> rules;

+ std::vector<linked_ptr<api::events::Rule>> rules;

rules.push_back(rule);

const Extension* extension = env()->MakeExtension(*base::test::ParseJson(