extensions/browser/api/runtime/runtime_api.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/runtime/runtime_api.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h ('k') | extensions/browser/api/runtime/runtime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/runtime/runtime_api.h

diff --git a/extensions/browser/api/runtime/runtime_api.h b/extensions/browser/api/runtime/runtime_api.h

index eb60c303bb2edc2a20a49212b0fdbc9f4d92e82a..6adfe2d2bb548a7df7cc5df64e619e0d7e2d98ed 100644

--- a/extensions/browser/api/runtime/runtime_api.h

+++ b/extensions/browser/api/runtime/runtime_api.h

@@ -29,7 +29,7 @@ class BrowserContext;

namespace extensions {

-namespace core_api {

+namespace api {

namespace runtime {

struct PlatformInfo;

}

@@ -62,7 +62,7 @@ class RuntimeAPI : public BrowserContextKeyedAPI,

bool CheckForUpdates(const std::string& extension_id,

const RuntimeAPIDelegate::UpdateCheckCallback& callback);

void OpenURL(const GURL& uninstall_url);

- bool GetPlatformInfo(core_api::runtime::PlatformInfo* info);

+ bool GetPlatformInfo(api::runtime::PlatformInfo* info);

bool RestartDevice(std::string* error_message);

bool OpenOptionsPage(const Extension* extension);

@@ -142,7 +142,7 @@ class RuntimeEventRouter {

static void DispatchOnRestartRequiredEvent(

content::BrowserContext* context,

const std::string& app_id,

- core_api::runtime::OnRestartRequiredReason reason);

+ api::runtime::OnRestartRequiredReason reason);

// Does any work needed at extension uninstall (e.g. load uninstall url).

static void OnExtensionUninstalled(content::BrowserContext* context,