chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc ('k') | chrome/browser/extensions/api/storage/managed_value_store_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

index a18abba39565c4bcefd3c8ddf99c736bd22eceb4..2b2a8fa1ab830ea2cab51124aa1369cbb6183716 100644

--- a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

+++ b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

@@ -17,7 +17,7 @@

#include "testing/gtest/include/gtest/gtest.h"

namespace extensions {

-namespace core_api {

+namespace api {

static scoped_ptr<KeyedService> ApiResourceManagerTestFactory(

content::BrowserContext* context) {

@@ -66,5 +66,5 @@ TEST_F(SocketsTcpServerUnitTest, Create) {

ASSERT_TRUE(result.get());

}

-} // namespace core_api

+} // namespace api

} // namespace extensions