extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/printer_provider/printer_provider_api.cc ('k') | extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h

diff --git a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h

index bb62b333883e8c4897496dfb4311f1de697f1abc..a842d6ad535d8822aa6cd0708442950233a81de7 100644

--- a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h

+++ b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h

@@ -74,7 +74,7 @@ class PrinterProviderInternalAPI : public BrowserContextKeyedAPI {

// |PrinterProviderInternalReportPrintResultFunction|.

void NotifyPrintResult(const Extension* extension,

int request_id,

- core_api::printer_provider_internal::PrintError error);

+ api::printer_provider_internal::PrintError error);

// Notifies observers that a printerProvider.onGetUsbPrinterInfoRequested

// callback has been called. Called from

@@ -82,7 +82,7 @@ class PrinterProviderInternalAPI : public BrowserContextKeyedAPI {

void NotifyGetUsbPrinterInfoResult(

const Extension* extension,

int request_id,

- const core_api::printer_provider::PrinterInfo* printer_info);

+ const api::printer_provider::PrinterInfo* printer_info);

base::ObserverList<PrinterProviderInternalAPIObserver> observers_;