extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h ('k') | extensions/browser/api/diagnostics/diagnostics_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

index 6af74acc876bdc1912b554ecd1443695667161aa..ef709b28aa2d4ecdba4a26be3b1d2a5aed281270 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

@@ -151,7 +151,7 @@ std::list<LinkedPtrEventResponseDelta> WebRequestRulesRegistry::CreateDeltas(

std::string WebRequestRulesRegistry::AddRulesImpl(

const std::string& extension_id,

- const std::vector<linked_ptr<core_api::events::Rule>>& rules) {

+ const std::vector<linked_ptr<api::events::Rule>>& rules) {

typedef std::pair<WebRequestRule::RuleId, linked_ptr<const WebRequestRule>>

IdRulePair;

typedef std::vector<IdRulePair> RulesVector;

@@ -166,7 +166,7 @@ std::string WebRequestRulesRegistry::AddRulesImpl(

extension_info_map_->extensions().GetByID(extension_id);

RulesMap& registered_rules = webrequest_rules_[extension_id];

- for (const linked_ptr<core_api::events::Rule>& rule : rules) {

+ for (const linked_ptr<api::events::Rule>& rule : rules) {

const WebRequestRule::RuleId& rule_id(*rule->id);

DCHECK(registered_rules.find(rule_id) == registered_rules.end());