extensions/browser/api/api_resource_manager.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/api_resource_manager.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/alarms/alarms_api_unittest.cc ('k') | extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/api_resource_manager.h

diff --git a/extensions/browser/api/api_resource_manager.h b/extensions/browser/api/api_resource_manager.h

index 29040d0421224298894dae44da2e67097084342b..713d6a316bc82fe44ec80df9bd697079dd0a9770 100644

--- a/extensions/browser/api/api_resource_manager.h

+++ b/extensions/browser/api/api_resource_manager.h

@@ -24,7 +24,7 @@

namespace extensions {

-namespace core_api {

+namespace api {

class BluetoothSocketApiFunction;

class BluetoothSocketEventDispatcher;

class SerialEventDispatcher;

@@ -192,12 +192,12 @@ class ApiResourceManager : public BrowserContextKeyedAPI,

// TODO(rockot): ApiResourceData could be moved out of ApiResourceManager and

// we could avoid maintaining a friends list here.

friend class BluetoothAPI;

- friend class core_api::BluetoothSocketApiFunction;

- friend class core_api::BluetoothSocketEventDispatcher;

- friend class core_api::SerialEventDispatcher;

- friend class core_api::TCPServerSocketEventDispatcher;

- friend class core_api::TCPSocketEventDispatcher;

- friend class core_api::UDPSocketEventDispatcher;

+ friend class api::BluetoothSocketApiFunction;

+ friend class api::BluetoothSocketEventDispatcher;

+ friend class api::SerialEventDispatcher;

+ friend class api::TCPServerSocketEventDispatcher;

+ friend class api::TCPSocketEventDispatcher;

+ friend class api::UDPSocketEventDispatcher;

friend class BrowserContextKeyedAPIFactory<ApiResourceManager<T> >;

static const bool kServiceHasOwnInstanceInIncognito = true;