extensions/shell/browser/shell_display_info_provider.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_display_info_provider.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/shell/browser/shell_display_info_provider.h ('k') | extensions/shell/browser/shell_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/shell_display_info_provider.cc

diff --git a/extensions/shell/browser/shell_display_info_provider.cc b/extensions/shell/browser/shell_display_info_provider.cc

index 1666136e2bd35f8b8766abcffb62210277ff287b..32239ab0a26170d9276a2c5169712931e0e9adb7 100644

--- a/extensions/shell/browser/shell_display_info_provider.cc

+++ b/extensions/shell/browser/shell_display_info_provider.cc

@@ -14,7 +14,7 @@ ShellDisplayInfoProvider::~ShellDisplayInfoProvider() {

bool ShellDisplayInfoProvider::SetInfo(

const std::string& display_id,

- const core_api::system_display::DisplayProperties& info,

+ const api::system_display::DisplayProperties& info,

std::string* error) {

*error = "Not implemented";

return false;

@@ -22,7 +22,7 @@ bool ShellDisplayInfoProvider::SetInfo(

void ShellDisplayInfoProvider::UpdateDisplayUnitInfoForPlatform(

const gfx::Display& display,

- extensions::core_api::system_display::DisplayUnitInfo* unit) {

+ extensions::api::system_display::DisplayUnitInfo* unit) {

static bool logged_once = false;

if (!logged_once) {

NOTIMPLEMENTED();