chrome/browser/extensions/api/networking_private/networking_private_apitest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

index 7bc876aec02efd29d4fb2af0aeb633f34d813df9..0325f4f2d59e6602073ad9eefd237155f9a9300b 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

@@ -152,10 +152,10 @@ class TestDelegate : public NetworkingPrivateDelegate {

if (fail_)

return result.Pass();

result.reset(new DeviceStateList);

- scoped_ptr<core_api::networking_private::DeviceStateProperties> properties(

- new core_api::networking_private::DeviceStateProperties);

- properties->type = core_api::networking_private::NETWORK_TYPE_ETHERNET;

- properties->state = core_api::networking_private::DEVICE_STATE_TYPE_ENABLED;

+ scoped_ptr<api::networking_private::DeviceStateProperties> properties(

+ new api::networking_private::DeviceStateProperties);

+ properties->type = api::networking_private::NETWORK_TYPE_ETHERNET;

+ properties->state = api::networking_private::DEVICE_STATE_TYPE_ENABLED;

result->push_back(properties.Pass());

return result.Pass();

}