extensions/browser/api/networking_config/networking_config_service_factory.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_service_factory.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_config/networking_config_service.cc ('k') | extensions/browser/api/networking_private/networking_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_service_factory.cc

diff --git a/extensions/browser/api/networking_config/networking_config_service_factory.cc b/extensions/browser/api/networking_config/networking_config_service_factory.cc

index 0c1c82b0887151c167f9a0a77c7a99476e233e32..b13302a5f6a30df2321789cb40fbb3859701b720 100644

--- a/extensions/browser/api/networking_config/networking_config_service_factory.cc

+++ b/extensions/browser/api/networking_config/networking_config_service_factory.cc

@@ -40,7 +40,7 @@ bool DefaultEventDelegate::HasExtensionRegisteredForEvent(

const std::string& extension_id) const {

return EventRouter::Get(context_)->ExtensionHasEventListener(

extension_id,

- core_api::networking_config::OnCaptivePortalDetected::kEventName);

+ api::networking_config::OnCaptivePortalDetected::kEventName);

}

} // namespace