extensions/browser/api/execute_code_function.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/execute_code_function.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/execute_code_function.h ('k') | extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/execute_code_function.cc

diff --git a/extensions/browser/api/execute_code_function.cc b/extensions/browser/api/execute_code_function.cc

index f4a565c455d273646da258773faf779bd7c5c6a4..0f98df344a75493bfb53590e96ea77806bf2cbba 100644

--- a/extensions/browser/api/execute_code_function.cc

+++ b/extensions/browser/api/execute_code_function.cc

@@ -33,7 +33,7 @@ const char kLoadFileError[] = "Failed to load file: \"*\". ";

namespace extensions {

-using core_api::extension_types::InjectDetails;

+using api::extension_types::InjectDetails;

ExecuteCodeFunction::ExecuteCodeFunction() {

}

@@ -149,14 +149,14 @@ bool ExecuteCodeFunction::Execute(const std::string& code_string) {

UserScript::RunLocation run_at = UserScript::UNDEFINED;

switch (details_->run_at) {

- case core_api::extension_types::RUN_AT_NONE:

- case core_api::extension_types::RUN_AT_DOCUMENT_IDLE:

+ case api::extension_types::RUN_AT_NONE:

+ case api::extension_types::RUN_AT_DOCUMENT_IDLE:

run_at = UserScript::DOCUMENT_IDLE;

break;

- case core_api::extension_types::RUN_AT_DOCUMENT_START:

+ case api::extension_types::RUN_AT_DOCUMENT_START:

run_at = UserScript::DOCUMENT_START;

break;

- case core_api::extension_types::RUN_AT_DOCUMENT_END:

+ case api::extension_types::RUN_AT_DOCUMENT_END:

run_at = UserScript::DOCUMENT_END;

break;

}