extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc ('k') | extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

index e622edc9fa10d7e6fa59c74a827aa3a4e21dcb34..3414f36768d3e0fae85f868af68cfc9702db8959 100644

--- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

+++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

@@ -51,8 +51,8 @@ class SocketsTcpServerApiTest : public ShellApiTest {

};

IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPCreateGood) {

- scoped_refptr<core_api::SocketsTcpServerCreateFunction>

- socket_create_function(new core_api::SocketsTcpServerCreateFunction());

+ scoped_refptr<api::SocketsTcpServerCreateFunction> socket_create_function(

+ new api::SocketsTcpServerCreateFunction());

scoped_refptr<Extension> empty_extension(test_util::CreateEmptyExtension());

socket_create_function->set_extension(empty_extension.get());