Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2878)

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
index fb42d5ce6869299e67b2040be5142d7ff39f74c2..70e0e6baa2ee36794c85f009eb76c7ac5c1db156 100644
--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
@@ -71,8 +71,8 @@ class RulesRegistryWithCacheTest : public testing::Test {
std::string AddRule(const std::string& extension_id,
const std::string& rule_id,
TestRulesRegistry* registry) {
- std::vector<linked_ptr<core_api::events::Rule>> add_rules;
- add_rules.push_back(make_linked_ptr(new core_api::events::Rule));
+ std::vector<linked_ptr<api::events::Rule>> add_rules;
+ add_rules.push_back(make_linked_ptr(new api::events::Rule));
add_rules[0]->id.reset(new std::string(rule_id));
return registry->AddRules(extension_id, add_rules);
}
@@ -91,7 +91,7 @@ class RulesRegistryWithCacheTest : public testing::Test {
int GetNumberOfRules(const std::string& extension_id,
TestRulesRegistry* registry) {
- std::vector<linked_ptr<core_api::events::Rule>> get_rules;
+ std::vector<linked_ptr<api::events::Rule>> get_rules;
registry->GetAllRules(extension_id, &get_rules);
return get_rules.size();
}
@@ -187,7 +187,7 @@ TEST_F(RulesRegistryWithCacheTest, GetRules) {
std::vector<std::string> rules_to_get;
rules_to_get.push_back(kRuleId);
rules_to_get.push_back("unknown_rule");
- std::vector<linked_ptr<core_api::events::Rule>> gotten_rules;
+ std::vector<linked_ptr<api::events::Rule>> gotten_rules;
registry_->GetRules(extension1_->id(), rules_to_get, &gotten_rules);
ASSERT_EQ(1u, gotten_rules.size());
ASSERT_TRUE(gotten_rules[0]->id.get());
@@ -201,7 +201,7 @@ TEST_F(RulesRegistryWithCacheTest, GetAllRules) {
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
// Check that we get the correct rules.
- std::vector<linked_ptr<core_api::events::Rule>> gotten_rules;
+ std::vector<linked_ptr<api::events::Rule>> gotten_rules;
registry_->GetAllRules(extension1_->id(), &gotten_rules);
EXPECT_EQ(2u, gotten_rules.size());
ASSERT_TRUE(gotten_rules[0]->id.get());

Powered by Google App Engine
This is Rietveld 408576698