extensions/browser/api/system_display/system_display_apitest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_display/system_display_apitest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/system_display/system_display_api.cc ('k') | extensions/browser/api/system_info/system_info_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_display/system_display_apitest.cc

diff --git a/extensions/browser/api/system_display/system_display_apitest.cc b/extensions/browser/api/system_display/system_display_apitest.cc

index ee7f0f626875efcaa68c1778944f63de43783a59..c88513dd31537f978b3ff35514857e97cd462304 100644

--- a/extensions/browser/api/system_display/system_display_apitest.cc

+++ b/extensions/browser/api/system_display/system_display_apitest.cc

@@ -15,8 +15,8 @@

namespace extensions {

-using core_api::system_display::Bounds;

-using core_api::system_display::DisplayUnitInfo;

+using api::system_display::Bounds;

+using api::system_display::DisplayUnitInfo;

using gfx::Screen;

class MockScreen : public Screen {

@@ -73,7 +73,7 @@ class MockDisplayInfoProvider : public DisplayInfoProvider {

~MockDisplayInfoProvider() override {}

bool SetInfo(const std::string& display_id,

- const core_api::system_display::DisplayProperties& params,

+ const api::system_display::DisplayProperties& params,

std::string* error) override {

// Should get called only once per test case.

EXPECT_FALSE(set_info_value_);

@@ -95,7 +95,7 @@ class MockDisplayInfoProvider : public DisplayInfoProvider {

// platform specific method.

void UpdateDisplayUnitInfoForPlatform(

const gfx::Display& display,

- extensions::core_api::system_display::DisplayUnitInfo* unit) override {

+ extensions::api::system_display::DisplayUnitInfo* unit) override {

int64 id = display.id();

unit->name = "DISPLAY NAME FOR " + base::Int64ToString(id);

if (id == 1)