extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc ('k') | extensions/browser/api/runtime/runtime_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h

diff --git a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h

index 27b8ee71ab1b92f268356df97d25fe5839d1b2a4..16dd8aa3a8dc32b1f639fc6a90b8865bea72bf7c 100644

--- a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h

+++ b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h

@@ -23,7 +23,7 @@ class Extension;

class PrinterProviderInternalAPIObserver {

public:

using PrinterInfoVector =

- std::vector<linked_ptr<core_api::printer_provider::PrinterInfo>>;

+ std::vector<linked_ptr<api::printer_provider::PrinterInfo>>;

// Used by chrome.printerProviderInternal API to report

// chrome.printerProvider.onGetPrintersRequested result returned by the

@@ -51,7 +51,7 @@ class PrinterProviderInternalAPIObserver {

virtual void OnPrintResult(

const Extension* extension,

int request_id,

- core_api::printer_provider_internal::PrintError error) = 0;

+ api::printer_provider_internal::PrintError error) = 0;

// Used by chrome.printerProviderInternal API to report

// chrome.printerProvider.onGetUsbPrinterInfoRequested result returned by the

@@ -61,7 +61,7 @@ class PrinterProviderInternalAPIObserver {

virtual void OnGetUsbPrinterInfoResult(

const Extension* extension,

int request_id,

- const core_api::printer_provider::PrinterInfo* printer_info) = 0;

+ const api::printer_provider::PrinterInfo* printer_info) = 0;

protected:

virtual ~PrinterProviderInternalAPIObserver() {}