Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed)

Created:
5 years, 5 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, shans, szager+layoutwatch_chromium.org, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, blink-reviews-css, blink-reviews-html_chromium.org, yurys+blink_chromium.org, Justin Novosad, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, blink-reviews-style_chromium.org, zoltan1, lushnikov+blink_chromium.org, darktears, Stephen Chennney, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, pfeldman+blink_chromium.org, f(malita), groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSSValue Immediates: Replace CSSPrimitiveValue usage with const references Replaced all instances of CSSValue, NullableCSSValue and CSSPrimitiveValue with const CSSValue&, const NullableCSSValue& and const CSSPrimitiveValue& respectively, where possible. This is an attempt to reduce ref-churn instroduced by CSSValue and CSSPrimitiveValue. Depends on crrev.com/1234763007. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -643 lines) Patch
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 5 chunks +14 lines, -13 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolationTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthPairStyleInterpolationTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ListStyleInterpolationTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ShadowStyleInterpolationTest.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 6 chunks +35 lines, -35 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 6 chunks +19 lines, -20 lines 0 comments Download
M Source/core/css/CSSCalculationValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 13 chunks +30 lines, -30 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/FontFace.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/Pair.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/Rect.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 29 chunks +55 lines, -55 lines 0 comments Download
M Source/core/css/parser/SizesCalcParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +25 lines, -25 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 25 chunks +48 lines, -48 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/resolver/StyleBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 3 chunks +56 lines, -56 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 40 chunks +98 lines, -98 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 29 chunks +49 lines, -49 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 25 chunks +35 lines, -35 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/PageSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PluginPlaceholderImplTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1234763007 Patch 60001

Dependent Patchsets:

Issue 1237653006 Patch 80001

Messages

Total messages: 1 (1 generated)
sashab
5 years, 4 months ago (2015-07-29 05:13:56 UTC) #1 
Patchset #3 (id:40001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698