Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/Rect.h ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index a53d9f3850c16d019ef7afbc94b60728caa95b7a..dda1f83551f52f199326e6248d8daf244f7ed678 100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -305,7 +305,7 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r
return;
StylePropertySet::PropertyReference contentProperty = propertySet.propertyAt(propertyIndex);
- CSSValue contentValue = contentProperty.value();
+ const CSSValue& contentValue = contentProperty.value();
if (!contentValue.isValueList())
return;
@@ -313,7 +313,7 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r
for (auto& item : toCSSValueList(contentValue)) {
if (!item.isPrimitiveValue())
continue;
- CSSPrimitiveValue primitiveItem = toCSSPrimitiveValue(item);
+ const CSSPrimitiveValue& primitiveItem = toCSSPrimitiveValue(item);
if (!primitiveItem.isAttr())
continue;
ensureAttributeInvalidationSet(AtomicString(primitiveItem.getStringValue()));
« no previous file with comments | « Source/core/css/Rect.h ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698