Source/core/editing/markup.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/markup.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/markup.cpp

diff --git a/Source/core/editing/markup.cpp b/Source/core/editing/markup.cpp

index 1e766c5182d30516531d6fd7b88ffeb3b4e707ea..0406263942a989f9537a3330eee6f93a28f0d34b 100644

--- a/Source/core/editing/markup.cpp

+++ b/Source/core/editing/markup.cpp

@@ -162,12 +162,12 @@ bool propertyMissingOrEqualToNone(StylePropertySet* style, CSSPropertyID propert

{

if (!style)

return false;

- NullableCSSValue value = style->getPropertyCSSValue(propertyID);

+ const NullableCSSValue& value = style->getPropertyCSSValue(propertyID);

if (!value)

return true;

if (!value->isPrimitiveValue())

return false;

- return toCSSPrimitiveValue(*value).getValueID() == CSSValueNone;

+ return toCSSPrimitiveValue(value).getValueID() == CSSValueNone;

}

static bool isPresentationalHTMLElement(const Node* node)

« no previous file with comments | « Source/core/editing/EditorCommand.cpp ('k') | Source/core/html/canvas/CanvasFontCache.cpp » ('j') | no next file with comments »