Source/core/animation/LengthBoxStyleInterpolation.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthBoxStyleInterpolation.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/DoubleStyleInterpolationTest.cpp ('k') | Source/core/animation/LengthPairStyleInterpolation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/LengthBoxStyleInterpolation.cpp

diff --git a/Source/core/animation/LengthBoxStyleInterpolation.cpp b/Source/core/animation/LengthBoxStyleInterpolation.cpp

index d3f9724e1867193e91daf3828fa0f84a7360b693..72baa5bb31fc15b18dd71e6710af7f8bd7cd7eb5 100644

--- a/Source/core/animation/LengthBoxStyleInterpolation.cpp

+++ b/Source/core/animation/LengthBoxStyleInterpolation.cpp

@@ -56,8 +56,8 @@ bool LengthBoxStyleInterpolation::usesDefaultInterpolation(const CSSValue& start

{

if (!start.isPrimitiveValue() || !end.isPrimitiveValue())

return false;

- const CSSPrimitiveValue startValue = toCSSPrimitiveValue(start);

- const CSSPrimitiveValue endValue = toCSSPrimitiveValue(end);

+ const CSSPrimitiveValue& startValue = toCSSPrimitiveValue(start);

+ const CSSPrimitiveValue& endValue = toCSSPrimitiveValue(end);

if ((startValue.isValueID() && startValue.getValueID() == CSSValueAuto)

|| (endValue.isValueID() && endValue.getValueID() == CSSValueAuto))

return true;

« no previous file with comments | « Source/core/animation/DoubleStyleInterpolationTest.cpp ('k') | Source/core/animation/LengthPairStyleInterpolation.cpp » ('j') | no next file with comments »