Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValuePool.cpp ('k') | Source/core/css/FontFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/Source/core/css/ComputedStyleCSSValueMapping.cpp b/Source/core/css/ComputedStyleCSSValueMapping.cpp
index 227178b291f37d7701ee9dd1ee630f9ae016b46c..bbaaedac6cbcfe90474f5d8040f2b255b603adbb 100644
--- a/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -238,10 +238,10 @@ static PassRefPtrWillBeRawPtr<CSSBorderImageSliceValue> valueForNinePieceImageSl
}
RefPtrWillBeRawPtr<Quad> quad = Quad::create();
- quad->setTop(toCSSPrimitiveValue(*top));
- quad->setRight(toCSSPrimitiveValue(*right));
- quad->setBottom(toCSSPrimitiveValue(*bottom));
- quad->setLeft(toCSSPrimitiveValue(*left));
+ quad->setTop(toCSSPrimitiveValue(top));
+ quad->setRight(toCSSPrimitiveValue(right));
+ quad->setBottom(toCSSPrimitiveValue(bottom));
+ quad->setLeft(toCSSPrimitiveValue(left));
return CSSBorderImageSliceValue::create(cssValuePool().createValue(quad.release()), image.fill());
}
@@ -290,10 +290,10 @@ static CSSPrimitiveValue valueForNinePieceImageQuad(const BorderImageLengthBox&
}
RefPtrWillBeRawPtr<Quad> quad = Quad::create();
- quad->setTop(toCSSPrimitiveValue(*top));
- quad->setRight(toCSSPrimitiveValue(*right));
- quad->setBottom(toCSSPrimitiveValue(*bottom));
- quad->setLeft(toCSSPrimitiveValue(*left));
+ quad->setTop(toCSSPrimitiveValue(top));
+ quad->setRight(toCSSPrimitiveValue(right));
+ quad->setBottom(toCSSPrimitiveValue(bottom));
+ quad->setLeft(toCSSPrimitiveValue(left));
return cssValuePool().createValue(quad.release());
}
@@ -322,7 +322,7 @@ static CSSValue valueForNinePieceImageRepeat(const NinePieceImage& image)
verticalRepeat = horizontalRepeat;
else
verticalRepeat = cssValuePool().createIdentifierValue(valueForRepeatRule(image.verticalRule()));
- return cssValuePool().createValue(Pair::create(toCSSPrimitiveValue(*horizontalRepeat), toCSSPrimitiveValue(*verticalRepeat), Pair::DropIdenticalValues));
+ return cssValuePool().createValue(Pair::create(toCSSPrimitiveValue(horizontalRepeat), toCSSPrimitiveValue(verticalRepeat), Pair::DropIdenticalValues));
}
static CSSValue valueForNinePieceImage(const NinePieceImage& image, const ComputedStyle& style)
@@ -378,7 +378,7 @@ static CSSValue valueForReflection(const StyleReflection* reflection, const Comp
break;
}
- return CSSReflectValue::create(toCSSPrimitiveValue(*direction), toCSSPrimitiveValue(*offset), valueForNinePieceImage(reflection->mask(), style));
+ return CSSReflectValue::create(toCSSPrimitiveValue(direction), toCSSPrimitiveValue(offset), valueForNinePieceImage(reflection->mask(), style));
}
static ItemPosition resolveAlignmentAuto(ItemPosition position, Node* element)
« no previous file with comments | « Source/core/css/CSSValuePool.cpp ('k') | Source/core/css/FontFace.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698