Source/core/css/StylePropertySerializer.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StylePropertySerializer.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/StylePropertySerializer.cpp

diff --git a/Source/core/css/StylePropertySerializer.cpp b/Source/core/css/StylePropertySerializer.cpp

index e2843e9247ec4d717869be55404e1516cefe6c7b..c33ad619b46071786c898a873e49ddf247e1bdab 100644

--- a/Source/core/css/StylePropertySerializer.cpp

+++ b/Source/core/css/StylePropertySerializer.cpp

@@ -658,8 +658,8 @@ String StylePropertySerializer::getLayeredShorthandValue(const StylePropertyShor

if (!value->isPrimitiveValue() || !yValue->isPrimitiveValue())

continue;

- CSSValueID xId = toCSSPrimitiveValue(*value).getValueID();

- CSSValueID yId = toCSSPrimitiveValue(*yValue).getValueID();

+ CSSValueID xId = toCSSPrimitiveValue(value).getValueID();

+ CSSValueID yId = toCSSPrimitiveValue(yValue).getValueID();

// Maybe advance propertyIndex to look at the next CSSValue in the list for the checks below.

if (xId == yId) {

useSingleWordShorthand = true;

« no previous file with comments | « Source/core/css/RuleFeature.cpp ('k') | Source/core/css/StylePropertySet.h » ('j') | no next file with comments »