CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Source/core/css/CSSValuePool.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 42 matching lines @@
     m_numberValueCache.resize(maximumCacheableIntegerValue + 1);
 }
 
 CSSPrimitiveValue CSSValuePool::createIdentifierValue(CSSValueID ident)
 {
     if (ident <= 0)
         return CSSPrimitiveValue::createIdentifier(ident);
 
     if (!m_identifierValueCache[ident])
         m_identifierValueCache[ident] = CSSPrimitiveValue::createIdentifier(ident);
-    return toCSSPrimitiveValue(*m_identifierValueCache[ident]);
+    return toCSSPrimitiveValue(m_identifierValueCache[ident]);
 }
 
 CSSPrimitiveValue CSSValuePool::createIdentifierValue(CSSPropertyID ident)
 {
     return CSSPrimitiveValue::createIdentifier(ident);
 }
 
 CSSPrimitiveValue CSSValuePool::createColorValue(unsigned rgbValue)
 {
     // These are the empty and deleted values of the hash table.
     if (rgbValue == Color::transparent)
         return toCSSPrimitiveValue(m_colorTransparent);
     if (rgbValue == Color::white)
         return toCSSPrimitiveValue(m_colorWhite);
     // Just because it is common.
     if (rgbValue == Color::black)
         return toCSSPrimitiveValue(m_colorBlack);
 
     // Just wipe out the cache and start rebuilding if it gets too big.
     const unsigned maximumColorCacheSize = 512;
     if (m_colorValueCache.size() > maximumColorCacheSize)
         m_colorValueCache.clear();
 
     NullableCSSValue dummyValue;
     ColorValueCache::AddResult entry = m_colorValueCache.add(rgbValue, dummyValue);
     if (entry.isNewEntry)
         entry.storedValue->value = CSSPrimitiveValue::createColor(rgbValue);
-    return toCSSPrimitiveValue(*entry.storedValue->value);
+    return toCSSPrimitiveValue(entry.storedValue->value);
 }
 
 CSSPrimitiveValue CSSValuePool::createValue(double value, CSSPrimitiveValue::UnitType type)
 {
     if (std::isinf(value))
         value = 0;
 
     if (value < 0 || value > maximumCacheableIntegerValue)
         return CSSPrimitiveValue::create(value, type);
 
     int intValue = static_cast<int>(value);
     if (value != intValue)
         return CSSPrimitiveValue::create(value, type);
 
     switch (type) {
     case CSSPrimitiveValue::CSS_PX:
         if (!m_pixelValueCache[intValue])
             m_pixelValueCache[intValue] = CSSPrimitiveValue::create(value, type);
-        return toCSSPrimitiveValue(*m_pixelValueCache[intValue]);
+        return toCSSPrimitiveValue(m_pixelValueCache[intValue]);
     case CSSPrimitiveValue::CSS_PERCENTAGE:
         if (!m_percentValueCache[intValue])
             m_percentValueCache[intValue] = CSSPrimitiveValue::create(value, type);
-        return toCSSPrimitiveValue(*m_percentValueCache[intValue]);
+        return toCSSPrimitiveValue(m_percentValueCache[intValue]);
     case CSSPrimitiveValue::CSS_NUMBER:
         if (!m_numberValueCache[intValue])
             m_numberValueCache[intValue] = CSSPrimitiveValue::create(value, type);
-        return toCSSPrimitiveValue(*m_numberValueCache[intValue]);
+        return toCSSPrimitiveValue(m_numberValueCache[intValue]);
     default:
         return CSSPrimitiveValue::create(value, type);
     }
 }
 
 CSSPrimitiveValue CSSValuePool::createValue(const Length& value, const ComputedStyle& style)
 {
     return CSSPrimitiveValue::create(value, style.effectiveZoom());
 }
 
 CSSPrimitiveValue CSSValuePool::createFontFamilyValue(const String& familyName)
 {
     NullableCSSValue& value = m_fontFamilyValueCache.add(familyName, nullptr).storedValue->value;
     if (!value)
         value = CSSPrimitiveValue::create(familyName, CSSPrimitiveValue::CSS_CUSTOM_IDENT);
-    return toCSSPrimitiveValue(*value);
+    return toCSSPrimitiveValue(value);
 }
 
 PassRefPtrWillBeRawPtr<CSSValueList> CSSValuePool::createFontFaceValue(const AtomicString& string)
 {
     // Just wipe out the cache and start rebuilding if it gets too big.
     const unsigned maximumFontFaceCacheSize = 128;
     if (m_fontFaceValueCache.size() > maximumFontFaceCacheSize)
         m_fontFaceValueCache.clear();
 
     RefPtrWillBeMember<CSSValueList>& value = m_fontFaceValueCache.add(string, nullptr).storedValue->value;
@@ skipping 19 matching lines @@
     visitor->trace(m_colorBlack);
     visitor->trace(m_pixelValueCache);
     visitor->trace(m_percentValueCache);
     visitor->trace(m_numberValueCache);
     visitor->trace(m_fontFaceValueCache);
     visitor->trace(m_fontFamilyValueCache);
 #endif
 }
 
 }