Source/web/PluginPlaceholderImplTest.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PluginPlaceholderImplTest.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PluginPlaceholderImplTest.cpp

diff --git a/Source/web/PluginPlaceholderImplTest.cpp b/Source/web/PluginPlaceholderImplTest.cpp

index fdb0c75328f9ca02eec0703d36034d14d98bb1ba..afb4f982dca8fb782bf5edd9851115abf6e5e7d2 100644

--- a/Source/web/PluginPlaceholderImplTest.cpp

+++ b/Source/web/PluginPlaceholderImplTest.cpp

@@ -99,8 +99,8 @@ bool isHiddenWithInlineStyle(Element* element)

{

if (!element->inlineStyle())

return false;

- NullableCSSValue value = element->inlineStyle()->getPropertyCSSValue(CSSPropertyDisplay);

- return value && value->isPrimitiveValue() && toCSSPrimitiveValue(*value).getValueID() == CSSValueNone;

+ const NullableCSSValue& value = element->inlineStyle()->getPropertyCSSValue(CSSPropertyDisplay);

+ return value && value->isPrimitiveValue() && toCSSPrimitiveValue(value).getValueID() == CSSValueNone;

}

TEST_F(PluginPlaceholderImplTest, Closeable)

« no previous file with comments | « Source/modules/canvas2d/CanvasRenderingContext2DState.cpp ('k') | no next file » | no next file with comments »