Source/core/css/CSSMatrix.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSMatrix.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSMatrix.cpp

diff --git a/Source/core/css/CSSMatrix.cpp b/Source/core/css/CSSMatrix.cpp

index 62757c14e61226ae659b1ad4a5d055c6d7ea3bd7..9eaffaac705243ab2879db8f7f926c501d603578 100644

--- a/Source/core/css/CSSMatrix.cpp

+++ b/Source/core/css/CSSMatrix.cpp

@@ -71,7 +71,7 @@ void CSSMatrix::setMatrixValue(const String& string, ExceptionState& exceptionSt

if (NullableCSSValue value = CSSParser::parseSingleValue(CSSPropertyTransform, string)) {

// Check for a "none" transform. In these cases we can use the default identity matrix.

- if (value->isPrimitiveValue() && (toCSSPrimitiveValue(*value).getValueID() == CSSValueNone))

+ if (value->isPrimitiveValue() && (toCSSPrimitiveValue(value).getValueID() == CSSValueNone))

return;

DEFINE_STATIC_REF(ComputedStyle, initialStyle, createInitialStyle());

« no previous file with comments | « Source/core/css/CSSGradientValue.cpp ('k') | Source/core/css/CSSStyleDeclaration.h » ('j') | no next file with comments »