Source/core/animation/ListStyleInterpolationTest.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ListStyleInterpolationTest.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/LengthStyleInterpolationTest.cpp ('k') | Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ListStyleInterpolationTest.cpp

diff --git a/Source/core/animation/ListStyleInterpolationTest.cpp b/Source/core/animation/ListStyleInterpolationTest.cpp

index f78e306c77a546ef84079e90ac1fe1e760f045f7..88b1eeb6c15a87bf2f336375184bf2e32c6b21f6 100644

--- a/Source/core/animation/ListStyleInterpolationTest.cpp

+++ b/Source/core/animation/ListStyleInterpolationTest.cpp

@@ -64,13 +64,13 @@ protected:

CSSShadowValue& expectedShadow = toCSSShadowValue(expectedList->item(i));

CSSShadowValue& actualShadow = toCSSShadowValue(toCSSValueList(actualList).item(i));

- EXPECT_EQ(toCSSPrimitiveValue(*expectedShadow.x).getDoubleValue(), toCSSPrimitiveValue(*actualShadow.x).getDoubleValue());

- EXPECT_EQ(toCSSPrimitiveValue(*expectedShadow.y).getDoubleValue(), toCSSPrimitiveValue(*actualShadow.y).getDoubleValue());

- EXPECT_EQ(toCSSPrimitiveValue(*expectedShadow.blur).getDoubleValue(), toCSSPrimitiveValue(*actualShadow.blur).getDoubleValue());

- EXPECT_EQ(toCSSPrimitiveValue(*expectedShadow.spread).getDoubleValue(), toCSSPrimitiveValue(*actualShadow.spread).getDoubleValue());

- EXPECT_EQ(toCSSPrimitiveValue(*expectedShadow.color).getRGBA32Value(), toCSSPrimitiveValue(*actualShadow.color).getRGBA32Value());

+ EXPECT_EQ(toCSSPrimitiveValue(expectedShadow.x).getDoubleValue(), toCSSPrimitiveValue(actualShadow.x).getDoubleValue());

+ EXPECT_EQ(toCSSPrimitiveValue(expectedShadow.y).getDoubleValue(), toCSSPrimitiveValue(actualShadow.y).getDoubleValue());

+ EXPECT_EQ(toCSSPrimitiveValue(expectedShadow.blur).getDoubleValue(), toCSSPrimitiveValue(actualShadow.blur).getDoubleValue());

+ EXPECT_EQ(toCSSPrimitiveValue(expectedShadow.spread).getDoubleValue(), toCSSPrimitiveValue(actualShadow.spread).getDoubleValue());

+ EXPECT_EQ(toCSSPrimitiveValue(expectedShadow.color).getRGBA32Value(), toCSSPrimitiveValue(actualShadow.color).getRGBA32Value());

- EXPECT_EQ(toCSSPrimitiveValue(*expectedShadow.style).getValueID(), toCSSPrimitiveValue(*actualShadow.style).getValueID());

+ EXPECT_EQ(toCSSPrimitiveValue(expectedShadow.style).getValueID(), toCSSPrimitiveValue(actualShadow.style).getValueID());

}

};