Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/DeferredLegacyStyleInterpolation.cpp
diff --git a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
index f570881f20558bc058806bc540547a4871681083..c27cfb755a7f14533fbf9cbc4182a470ed1071ba 100644
--- a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
+++ b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
@@ -43,7 +43,7 @@ void DeferredLegacyStyleInterpolation::apply(StyleResolverState& state) const
m_innerInterpolation->apply(state);
}
-bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValue value)
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValue& value)
{
// FIXME: should not require resolving styles for inherit/initial/unset.
if (value.isCSSWideKeyword())
@@ -62,7 +62,7 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
return true;
}
-bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSPrimitiveValue primitiveValue)
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSPrimitiveValue& primitiveValue)
{
// FIXME: consider other types.
if (primitiveValue.isNumber() || primitiveValue.isPercentage() || primitiveValue.isAngle() || primitiveValue.isRGBColor() || primitiveValue.isURI())
@@ -85,8 +85,8 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
}
if (Pair* pair = primitiveValue.getPairValue()) {
- return interpolationRequiresStyleResolve(*pair->first())
- || interpolationRequiresStyleResolve(*pair->second());
+ return interpolationRequiresStyleResolve(pair->first())
+ || interpolationRequiresStyleResolve(pair->second());
}
if (Rect* rect = primitiveValue.getRectValue()) {
« no previous file with comments | « Source/core/animation/DeferredLegacyStyleInterpolation.h ('k') | Source/core/animation/DoubleStyleInterpolation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698