Source/core/css/Rect.h - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/Rect.h

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/Rect.h

diff --git a/Source/core/css/Rect.h b/Source/core/css/Rect.h

index 2ce8b26ae89ae020a4f15c9520625d282f4eb332..d4f14599ed1f70a481c544297e678aa7fb4bd5d0 100644

--- a/Source/core/css/Rect.h

+++ b/Source/core/css/Rect.h

@@ -31,10 +31,10 @@ namespace blink {

class CORE_EXPORT RectBase : public RefCountedWillBeGarbageCollectedFinalized<RectBase> {

DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(RectBase);

public:

- CSSPrimitiveValue top() const { return toCSSPrimitiveValue(*m_top); }

- CSSPrimitiveValue right() const { return toCSSPrimitiveValue(*m_right); }

- CSSPrimitiveValue bottom() const { return toCSSPrimitiveValue(*m_bottom); }

- CSSPrimitiveValue left() const { return toCSSPrimitiveValue(*m_left); }

+ CSSPrimitiveValue top() const { return toCSSPrimitiveValue(m_top); }

+ CSSPrimitiveValue right() const { return toCSSPrimitiveValue(m_right); }

+ CSSPrimitiveValue bottom() const { return toCSSPrimitiveValue(m_bottom); }

+ CSSPrimitiveValue left() const { return toCSSPrimitiveValue(m_left); }

void setTop(CSSPrimitiveValue top) { m_top = top; }

void setRight(CSSPrimitiveValue right) { m_right = right; }

« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »