Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: Source/core/animation/ShadowStyleInterpolationTest.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/ShadowStyleInterpolation.cpp ('k') | Source/core/animation/StringKeyframe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/ShadowStyleInterpolationTest.cpp
diff --git a/Source/core/animation/ShadowStyleInterpolationTest.cpp b/Source/core/animation/ShadowStyleInterpolationTest.cpp
index ea910601c5c4918d6062de4d1a6d1c7a803402a0..0b34f742db5d000addaa73ab1152e5e384b9c76d 100644
--- a/Source/core/animation/ShadowStyleInterpolationTest.cpp
+++ b/Source/core/animation/ShadowStyleInterpolationTest.cpp
@@ -41,18 +41,18 @@ protected:
CSSShadowValue& shadowValue = toCSSShadowValue(value);
- EXPECT_EQ(xExpected, toCSSPrimitiveValue(*shadowValue.x).getDoubleValue());
- EXPECT_EQ(yExpected, toCSSPrimitiveValue(*shadowValue.y).getDoubleValue());
- EXPECT_EQ(blurExpected, toCSSPrimitiveValue(*shadowValue.blur).getDoubleValue());
- EXPECT_EQ(spreadExpected, toCSSPrimitiveValue(*shadowValue.spread).getDoubleValue());
- EXPECT_EQ(colorExpected, toCSSPrimitiveValue(*shadowValue.color).getRGBA32Value());
-
- EXPECT_EQ(idExpected.getValueID(), toCSSPrimitiveValue(*shadowValue.style).getValueID());
-
- EXPECT_EQ(toCSSPrimitiveValue(*shadowValue.x).primitiveType(), unitType);
- EXPECT_EQ(toCSSPrimitiveValue(*shadowValue.y).primitiveType(), unitType);
- EXPECT_EQ(toCSSPrimitiveValue(*shadowValue.blur).primitiveType(), unitType);
- EXPECT_EQ(toCSSPrimitiveValue(*shadowValue.spread).primitiveType(), unitType);
+ EXPECT_EQ(xExpected, toCSSPrimitiveValue(shadowValue.x).getDoubleValue());
+ EXPECT_EQ(yExpected, toCSSPrimitiveValue(shadowValue.y).getDoubleValue());
+ EXPECT_EQ(blurExpected, toCSSPrimitiveValue(shadowValue.blur).getDoubleValue());
+ EXPECT_EQ(spreadExpected, toCSSPrimitiveValue(shadowValue.spread).getDoubleValue());
+ EXPECT_EQ(colorExpected, toCSSPrimitiveValue(shadowValue.color).getRGBA32Value());
+
+ EXPECT_EQ(idExpected.getValueID(), toCSSPrimitiveValue(shadowValue.style).getValueID());
+
+ EXPECT_EQ(toCSSPrimitiveValue(shadowValue.x).primitiveType(), unitType);
+ EXPECT_EQ(toCSSPrimitiveValue(shadowValue.y).primitiveType(), unitType);
+ EXPECT_EQ(toCSSPrimitiveValue(shadowValue.blur).primitiveType(), unitType);
+ EXPECT_EQ(toCSSPrimitiveValue(shadowValue.spread).primitiveType(), unitType);
}
};
« no previous file with comments | « Source/core/animation/ShadowStyleInterpolation.cpp ('k') | Source/core/animation/StringKeyframe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698