Source/core/css/CSSCalculationValueTest.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValueTest.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCalculationValueTest.cpp

diff --git a/Source/core/css/CSSCalculationValueTest.cpp b/Source/core/css/CSSCalculationValueTest.cpp

index 1ca4619e330367f50a9b4b59961a9b79e948b99c..00f43b4ae6bf902242e02bace569f05d790f23c5 100644

--- a/Source/core/css/CSSCalculationValueTest.cpp

+++ b/Source/core/css/CSSCalculationValueTest.cpp

@@ -70,7 +70,7 @@ CSSLengthArray& setLengthArray(CSSLengthArray& lengthArray, String text)

initLengthArray(lengthArray);

RefPtrWillBeRawPtr<MutableStylePropertySet> propertySet = MutableStylePropertySet::create();

propertySet->setProperty(CSSPropertyLeft, text);

- toCSSPrimitiveValue(*propertySet->getPropertyCSSValue(CSSPropertyLeft)).accumulateLengthArray(lengthArray);

+ toCSSPrimitiveValue(propertySet->getPropertyCSSValue(CSSPropertyLeft)).accumulateLengthArray(lengthArray);

return lengthArray;

}

« no previous file with comments | « Source/core/css/CSSBasicShapes.cpp ('k') | Source/core/css/CSSComputedStyleDeclaration.h » ('j') | no next file with comments »