Source/core/animation/ShadowStyleInterpolation.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ShadowStyleInterpolation.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp ('k') | Source/core/animation/ShadowStyleInterpolationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ShadowStyleInterpolation.cpp

diff --git a/Source/core/animation/ShadowStyleInterpolation.cpp b/Source/core/animation/ShadowStyleInterpolation.cpp

index adf267e4beaffaba402b1f72f1db82382fa49495..8bdaaef5e8757e86859b3d260212bd1a4cbcdcd9 100644

--- a/Source/core/animation/ShadowStyleInterpolation.cpp

+++ b/Source/core/animation/ShadowStyleInterpolation.cpp

@@ -42,7 +42,7 @@ PassOwnPtrWillBeRawPtr<InterpolableValue> ShadowStyleInterpolation::toInterpolab

result->set(4, ColorStyleInterpolation::colorToInterpolableValue(CSSValue(*shadowValue.color.get())));

if (shadowValue.style)

- nonInterpolableData = (toCSSPrimitiveValue(*shadowValue.style).getValueID() == CSSValueInset);

+ nonInterpolableData = (toCSSPrimitiveValue(shadowValue.style).getValueID() == CSSValueInset);

else

nonInterpolableData = false;