Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: Source/core/animation/animatable/AnimatableUnknown.h

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/animatable/AnimatableImage.cpp ('k') | Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/animatable/AnimatableUnknown.h
diff --git a/Source/core/animation/animatable/AnimatableUnknown.h b/Source/core/animation/animatable/AnimatableUnknown.h
index 91d46e4410a5bb0156425c42eef0bbce43154563..1e9429091ef87cc52a5793d20de4301cdf58ec55 100644
--- a/Source/core/animation/animatable/AnimatableUnknown.h
+++ b/Source/core/animation/animatable/AnimatableUnknown.h
@@ -42,7 +42,7 @@ class AnimatableUnknown final : public AnimatableValue {
public:
virtual ~AnimatableUnknown() { }
- static PassRefPtrWillBeRawPtr<AnimatableUnknown> create(CSSPrimitiveValue value)
+ static PassRefPtrWillBeRawPtr<AnimatableUnknown> create(const CSSPrimitiveValue& value)
{
return adoptRefWillBeNoop(new AnimatableUnknown(value));
}
@@ -51,7 +51,7 @@ public:
return adoptRefWillBeNoop(new AnimatableUnknown(cssValuePool().createIdentifierValue(value)));
}
- CSSPrimitiveValue toCSSValue() const { return toCSSPrimitiveValue(m_value); }
+ const CSSPrimitiveValue& toCSSValue() const { return toCSSPrimitiveValue(m_value); }
CSSValueID toCSSValueID() const { return toCSSPrimitiveValue(m_value).getValueID(); }
DEFINE_INLINE_VIRTUAL_TRACE()
@@ -69,7 +69,7 @@ protected:
virtual bool usesDefaultInterpolationWith(const AnimatableValue*) const override { return true; }
private:
- explicit AnimatableUnknown(CSSPrimitiveValue value)
+ explicit AnimatableUnknown(const CSSPrimitiveValue& value)
: m_value(value)
{
}
« no previous file with comments | « Source/core/animation/animatable/AnimatableImage.cpp ('k') | Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698