Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: Source/core/layout/svg/ReferenceFilterBuilder.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/LayoutEditor.cpp ('k') | Source/core/page/PageSerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/svg/ReferenceFilterBuilder.cpp
diff --git a/Source/core/layout/svg/ReferenceFilterBuilder.cpp b/Source/core/layout/svg/ReferenceFilterBuilder.cpp
index c426cc90db5239d3e391370745fa882f329c5aa8..9977c8771eb6f3b5cee3ccca17e700ea3d8ae91c 100644
--- a/Source/core/layout/svg/ReferenceFilterBuilder.cpp
+++ b/Source/core/layout/svg/ReferenceFilterBuilder.cpp
@@ -76,9 +76,9 @@ static EColorInterpolation colorInterpolationForElement(SVGElement& element, ECo
// No layout has been performed, try to determine the property value
// "manually" (used by external SVG files.)
if (const StylePropertySet* propertySet = element.presentationAttributeStyle()) {
- NullableCSSValue cssValue = propertySet->getPropertyCSSValue(CSSPropertyColorInterpolationFilters);
+ const NullableCSSValue& cssValue = propertySet->getPropertyCSSValue(CSSPropertyColorInterpolationFilters);
if (cssValue && cssValue->isPrimitiveValue()) {
- const CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(*cssValue);
+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(cssValue);
return static_cast<EColorInterpolation>(primitiveValue);
}
}
« no previous file with comments | « Source/core/inspector/LayoutEditor.cpp ('k') | Source/core/page/PageSerializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698