Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158523002: Add user_gesture param to BaseWindow::Show

Created:
5 years, 7 months ago by johnme
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, extensions-reviews_chromium.org, jennb, tfarina, Dmitry Titov, jianli, dcheng, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : Add parameter #

Patch Set 2 : Update callers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -73 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/net/sdch_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/aura/tab_contents/web_drag_bookmark_handler_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 7 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/scoped_tabbed_browser_displayer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/settings_window_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/components/native_app_window/native_app_window_views.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/components/native_app_window/native_app_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_native_app_window_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_native_app_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/base_window.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
johnme
Note to reviewers: I've split up adding the parameter into the 1st patch set and ...
5 years, 7 months ago (2015-05-22 16:42:51 UTC) #2
Avi (use Gerrit)
5 years, 7 months ago (2015-05-22 21:31:24 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698