chrome/browser/ui/browser_navigator.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index 8c10fe0ae0a4b7f9d1293ce50e02af1540530f7a..774ec7db3d48c6cadc591f676112dd196f1bca73 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -296,7 +296,7 @@ class ScopedBrowserShower {

chrome::NavigateParams::SHOW_WINDOW_INACTIVE) {

params_->browser->window()->ShowInactive();

} else if (params_->window_action == chrome::NavigateParams::SHOW_WINDOW) {

- params_->browser->window()->Show();

+ params_->browser->window()->Show(params_->user_gesture);

// If a user gesture opened a popup window, focus the contents.

if (params_->user_gesture && params_->disposition == NEW_POPUP &&

params_->target_contents) {