Add user_gesture param to BaseWindow::Show

chrome/browser/ui/extensions/application_launch.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/application_launch.h"
 
 #include <string>
 
 #include "apps/launcher.h"
 #include "base/metrics/histogram.h"
@@ skipping 191 matching lines @@
                                                                params.container,
                                                                extension);
 
   Browser* browser = new Browser(browser_params);
 
   WebContents* web_contents = chrome::AddSelectedTabWithURL(
       browser, url, ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
   web_contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   web_contents->GetRenderViewHost()->SyncRendererPrefs();
 
-  browser->window()->Show();
+  // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+  browser->window()->Show(false /* user_gesture */);
 
   // TODO(jcampan): http://crbug.com/8123 we should not need to set the initial
   //                focus explicitly.
   web_contents->SetInitialFocus();
   return web_contents;
 }
 
 WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
                            const GURL& url) {
   const Extension* extension = GetExtension(launch_params);
   CHECK(extension);
   Profile* const profile = launch_params.profile;
   WindowOpenDisposition disposition = launch_params.disposition;
+  // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+  bool user_gesture = false;
 
   Browser* browser = chrome::FindTabbedBrowser(profile,
                                                false,
                                                launch_params.desktop_type);
   WebContents* contents = NULL;
   if (!browser) {
     // No browser for this profile, need to open a new one.
     browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED,
                                                 profile,
                                                 launch_params.desktop_type));
-    browser->window()->Show();
+    browser->window()->Show(user_gesture);
     // There's no current tab in this browser window, so add a new one.
     disposition = NEW_FOREGROUND_TAB;
   } else {
     // For existing browser, ensure its window is shown and activated.
-    browser->window()->Show();
-    // TODO(johnme): Can we sometimes be certain this was for a user gesture?
-    browser->window()->Activate(false /* user_gesture */);
+    browser->window()->Show(user_gesture);
+    browser->window()->Activate(user_gesture);
   }
 
   extensions::LaunchType launch_type =
       extensions::GetLaunchType(ExtensionPrefs::Get(profile), extension);
   UMA_HISTOGRAM_ENUMERATION("Extensions.AppTabLaunchType", launch_type, 100);
 
   int add_type = TabStripModel::ADD_ACTIVE;
   if (launch_type == extensions::LAUNCH_TYPE_PINNED)
     add_type |= TabStripModel::ADD_PINNED;
 
@@ skipping 153 matching lines @@
   extensions::TabHelper::FromWebContents(tab)->UpdateShortcutOnLoadComplete();
 
   return tab;
 }
 
 bool CanLaunchViaEvent(const extensions::Extension* extension) {
   const extensions::Feature* feature =
       extensions::FeatureProvider::GetAPIFeature("app.runtime");
   return feature->IsAvailableToExtension(extension).is_available();
 }