Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/panels/panel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index fa637deaa05f57beed47cb14a41e8cb0b7b5af83..100fb377ecb45ff7296419cd2eb22d0ceb4fa040 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -1335,7 +1335,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate) {
chrome::AddSelectedTabWithURL(incognito_browser, url,
ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
observer.Wait();
- incognito_browser->window()->Show();
+ incognito_browser->window()->Show(false /* user_gesture */);
// Open the find box and make sure that it is prepopulated with "page".
EnsureFindBoxOpenForBrowser(incognito_browser);
@@ -1400,7 +1400,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FitWindow) {
popup, GURL(url::kAboutBlankURL), ui::PAGE_TRANSITION_LINK);
// Wait for the page to finish loading.
observer.Wait();
- popup->window()->Show();
+ popup->window()->Show(false /* user_gesture */);
// On GTK, bounds change is asynchronous.
base::MessageLoop::current()->RunUntilIdle();
« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/panels/panel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698