chrome/browser/ui/settings_window_manager.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/settings_window_manager.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/settings_window_manager.cc

diff --git a/chrome/browser/ui/settings_window_manager.cc b/chrome/browser/ui/settings_window_manager.cc

index 5e4954b8cae94a56c555b510fad6ebe02f7ebb48..6ca60891a94fb72094117417757f5b64dc3c3032 100644

--- a/chrome/browser/ui/settings_window_manager.cc

+++ b/chrome/browser/ui/settings_window_manager.cc

@@ -47,7 +47,7 @@ void SettingsWindowManager::ShowChromePageForProfile(Profile* profile,

const content::WebContents* web_contents =

browser->tab_strip_model()->GetWebContentsAt(0);

if (web_contents && web_contents->GetURL() == gurl) {

- browser->window()->Show();

+ browser->window()->Show(true /* user_gesture */);

return;

}

NavigateParams params(browser, gurl,