chrome/browser/ui/scoped_tabbed_browser_displayer.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/scoped_tabbed_browser_displayer.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/scoped_tabbed_browser_displayer.cc

diff --git a/chrome/browser/ui/scoped_tabbed_browser_displayer.cc b/chrome/browser/ui/scoped_tabbed_browser_displayer.cc

index 05fac0c37507f842df5720dcb43f864fc325ce2f..bdcfac437b7fab30088447074ef4d4c899717692 100644

--- a/chrome/browser/ui/scoped_tabbed_browser_displayer.cc

+++ b/chrome/browser/ui/scoped_tabbed_browser_displayer.cc

@@ -19,7 +19,8 @@ ScopedTabbedBrowserDisplayer::ScopedTabbedBrowserDisplayer(

}

ScopedTabbedBrowserDisplayer::~ScopedTabbedBrowserDisplayer() {

- browser_->window()->Show();

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

+ browser_->window()->Show(false /* user_gesture */);

}

} // namespace chrome