extensions/browser/app_window/app_window.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index c1959a98c82541c665e543ff7fba235de8b74b5f..b3555e206fc4c8bc839dc560564f88b49121184b 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -640,7 +640,8 @@ void AppWindow::Show(ShowType show_type) {

switch (show_type) {

case SHOW_ACTIVE:

- GetBaseWindow()->Show();

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

+ GetBaseWindow()->Show(false /* user_gesture */);

break;

case SHOW_INACTIVE:

GetBaseWindow()->ShowInactive();