Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1153793003: Add user_gesture param to WebContentsImpl::Activate

Created:
5 years, 7 months ago by johnme
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add user_gesture param to WebContentsImpl::Activate This will be used for https://codereview.chromium.org/1135693006 BUG=470830, 489256, 411702

Patch Set 1 : Add parameter #

Patch Set 2 : Update callers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
johnme
Note to reviewers: I've split up adding the parameter into the 1st patch set and ...
5 years, 7 months ago (2015-05-22 16:42:36 UTC) #2
Avi (use Gerrit)
5 years, 7 months ago (2015-05-22 21:25:17 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698