chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index d3d6a9bf77ec6d4a1ecf8dcb1c520ff52a7ed974..978291344f5062dd3cbcab29e0e78e606b6c9bd2 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -143,7 +143,7 @@ BrowserWindowCocoa::~BrowserWindowCocoa() {

browser_->search_model()->RemoveObserver(this);

}

-void BrowserWindowCocoa::Show() {

+void BrowserWindowCocoa::Show(bool user_gesture) {

// The Browser associated with this browser window must become the active

// browser at the time |Show()| is called. This is the natural behaviour under

// Windows, but |-makeKeyAndOrderFront:| won't send |-windowDidBecomeMain:|