chrome/browser/ui/scoped_tabbed_browser_displayer.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/scoped_tabbed_browser_displayer.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | chrome/browser/ui/settings_window_manager.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"	5 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"

6	6

7 #include "chrome/browser/ui/browser.h"	7 #include "chrome/browser/ui/browser.h"

8 #include "chrome/browser/ui/browser_finder.h"	8 #include "chrome/browser/ui/browser_finder.h"

9 #include "chrome/browser/ui/browser_window.h"	9 #include "chrome/browser/ui/browser_window.h"

10	10

11 namespace chrome {	11 namespace chrome {

12	12

13 ScopedTabbedBrowserDisplayer::ScopedTabbedBrowserDisplayer(	13 ScopedTabbedBrowserDisplayer::ScopedTabbedBrowserDisplayer(

14 Profile* profile,	14 Profile* profile,

15 HostDesktopType type) {	15 HostDesktopType type) {

16 browser_ = FindTabbedBrowser(profile, false, type);	16 browser_ = FindTabbedBrowser(profile, false, type);

17 if (!browser_)	17 if (!browser_)

18 browser_ = new Browser(Browser::CreateParams(profile, type));	18 browser_ = new Browser(Browser::CreateParams(profile, type));

19 }	19 }

20	20

21 ScopedTabbedBrowserDisplayer::~ScopedTabbedBrowserDisplayer() {	21 ScopedTabbedBrowserDisplayer::~ScopedTabbedBrowserDisplayer() {

22 browser_->window()->Show();	22 // TODO(johnme): Can we sometimes be certain this was for a user gesture?

	23 browser_->window()->Show(false /* user_gesture */);

23 }	24 }

24	25

25 } // namespace chrome	26 } // namespace chrome

OLD	NEW