Add user_gesture param to BaseWindow::Show

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_util.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
@@ skipping 84 matching lines @@
                        std::string* error) {
   content::WebContents* web_contents = function->GetAssociatedWebContents();
   chrome::HostDesktopType desktop_type =
       web_contents && web_contents->GetNativeView()
           ? chrome::GetHostDesktopTypeForNativeView(
                 web_contents->GetNativeView())
           : chrome::GetHostDesktopTypeForNativeView(NULL);
   Browser::CreateParams params(
       Browser::TYPE_TABBED, function->GetProfile(), desktop_type);
   Browser* browser = new Browser(params);
-  browser->window()->Show();
+  // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+  browser->window()->Show(false /* user_gesture */);
   return browser;
 }
 
 }  // namespace
 
 ExtensionTabUtil::OpenTabParams::OpenTabParams()
     : create_browser_if_needed(false) {
 }
 
 ExtensionTabUtil::OpenTabParams::~OpenTabParams() {
@@ skipping 94 matching lines @@
   if (url.SchemeIs(kExtensionScheme) &&
       !IncognitoInfo::IsSplitMode(function->extension()) &&
       browser->profile()->IsOffTheRecord()) {
     Profile* profile = browser->profile()->GetOriginalProfile();
     chrome::HostDesktopType desktop_type = browser->host_desktop_type();
 
     browser = chrome::FindTabbedBrowser(profile, false, desktop_type);
     if (!browser) {
       browser = new Browser(
           Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
-      browser->window()->Show();
+      // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+      browser->window()->Show(false /* user_gesture */);
     }
   }
 
   // If index is specified, honor the value, but keep it bound to
   // -1 <= index <= tab_strip->count() where -1 invokes the default behavior.
   int index = -1;
   if (params.index.get())
     index = *params.index;
 
   TabStripModel* tab_strip = browser->tab_strip_model();
@@ skipping 380 matching lines @@
 
   chrome::NavigateParams params(
       chrome::GetSingletonTabNavigateParams(browser, url_to_navigate));
   params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
   params.url = url_to_navigate;
   chrome::ShowSingletonTabOverwritingNTP(browser, params);
   return true;
 }
 
 }  // namespace extensions