chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

index 0c263b8f0e0c9a31321f1b853218bf5ac0bdd5ff..2abaef0d9fac1cccfe9842f98a4f17a0684114a5 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.cc

@@ -49,7 +49,7 @@ void ChromeLauncherAppMenuItemTab::Execute(int event_flags) {

multi_user_util::MoveWindowToCurrentDesktop(

browser->window()->GetNativeWindow());

tab_strip->ActivateTabAt(index, false);

- browser->window()->Show();

+ browser->window()->Show(true /* user_gesture */);

// Need this check to prevent unit tests from crashing.

if (browser->window()->GetNativeWindow())

ash::wm::ActivateWindow(browser->window()->GetNativeWindow());