chrome/browser/ui/passwords/manage_passwords_test.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_test.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc

index 5d2aa8d7b3d85971b8ea81723752a711873f0da3..775c2facb7dade408a70c5407d3da0d26a3e0d2f 100644

--- a/chrome/browser/ui/passwords/manage_passwords_test.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc

@@ -33,7 +33,7 @@ void ManagePasswordsTest::SetUpOnMainThread() {

void ManagePasswordsTest::ExecuteManagePasswordsCommand() {

// Show the window to ensure that it's active.

- browser()->window()->Show();

+ browser()->window()->Show(false /* user_gesture */);

CommandUpdater* updater = browser()->command_controller()->command_updater();

EXPECT_TRUE(updater->IsCommandEnabled(IDC_MANAGE_PASSWORDS_FOR_PAGE));