chrome/browser/ui/browser_focus_uitest.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_focus_uitest.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_focus_uitest.cc

diff --git a/chrome/browser/ui/browser_focus_uitest.cc b/chrome/browser/ui/browser_focus_uitest.cc

index d1ad77c547b84f95abe008fe068ea8afc31223c6..27edc6389ccd92d4314f1cbe6097483d08e7ffe0 100644

--- a/chrome/browser/ui/browser_focus_uitest.cc

+++ b/chrome/browser/ui/browser_focus_uitest.cc

@@ -351,7 +351,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest,

browser()->host_desktop_type()));

ASSERT_TRUE(browser2);

chrome::AddTabAt(browser2, GURL(), -1, true);

- browser2->window()->Show();

+ browser2->window()->Show(false /* user_gesture */);

Browser* focused_browser = NULL;

Browser* unfocused_browser = NULL;

« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »