chrome/browser/ui/browser_tab_restore_service_delegate.cc - Issue 1158523002: Add user_gesture param to BaseWindow::Show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tab_restore_service_delegate.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_tab_restore_service_delegate.cc

diff --git a/chrome/browser/ui/browser_tab_restore_service_delegate.cc b/chrome/browser/ui/browser_tab_restore_service_delegate.cc

index 75e1c24e0a7077c513299517252e4a24ffce7dfe..b34f48ac1984ad9a5763d476bf8349d7192d4c7f 100644

--- a/chrome/browser/ui/browser_tab_restore_service_delegate.cc

+++ b/chrome/browser/ui/browser_tab_restore_service_delegate.cc

@@ -17,7 +17,8 @@ using content::SessionStorageNamespace;

using content::WebContents;

void BrowserTabRestoreServiceDelegate::ShowBrowserWindow() {

- browser_->window()->Show();

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

+ browser_->window()->Show(false /* user_gesture */);

}

const SessionID& BrowserTabRestoreServiceDelegate::GetSessionID() const {

« no previous file with comments | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »