Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149263003: Add user_gesture param to BaseWindow::Activate

Created:
5 years, 7 months ago by johnme
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, extensions-reviews_chromium.org, jennb, tfarina, Dmitry Titov, jianli, dcheng, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add user_gesture param to BaseWindow::Activate This will be used for https://codereview.chromium.org/1135693006 Depends on: - https://codereview.chromium.org/1153793003 - https://codereview.chromium.org/1153813003 BUG=470830, 489256, 411702

Patch Set 1 : Add parameter #

Patch Set 2 : Update callers #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -61 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 2 chunks +7 lines, -7 lines 1 comment Download
M chrome/browser/ui/browser_tabrestore.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/detached_panel_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/stacked_panel_collection.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/components/native_app_window/native_app_window_views.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/components/native_app_window/native_app_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_native_app_window_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_native_app_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/base_window.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
johnme
Note to reviewers: I've split up adding the parameter into the 1st patch set and ...
5 years, 7 months ago (2015-05-22 16:42:46 UTC) #2
Avi (use Gerrit)
5 years, 7 months ago (2015-05-22 21:27:25 UTC) #3 
lgtm

https://codereview.chromium.org/1149263003/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_focus_uitest.cc (right):

https://codereview.chromium.org/1149263003/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_focus_uitest.cc:668: // #endif
Don't touch this code; your patch is big enough :)

Powered by Google App Engine
This is Rietveld 408576698