Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6993)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index fa51e7a1d851a08423dd5caca820ff73e9dd02f5..c637958e633dcbe212608face0b0558f142c537c 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -209,7 +209,8 @@ WebContents* OpenApplicationWindow(const AppLaunchParams& params,
web_contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
web_contents->GetRenderViewHost()->SyncRendererPrefs();
- browser->window()->Show();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Show(false /* user_gesture */);
// TODO(jcampan): http://crbug.com/8123 we should not need to set the initial
// focus explicitly.
@@ -223,6 +224,8 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
CHECK(extension);
Profile* const profile = launch_params.profile;
WindowOpenDisposition disposition = launch_params.disposition;
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ bool user_gesture = false;
Browser* browser = chrome::FindTabbedBrowser(profile,
false,
@@ -233,14 +236,13 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED,
profile,
launch_params.desktop_type));
- browser->window()->Show();
+ browser->window()->Show(user_gesture);
// There's no current tab in this browser window, so add a new one.
disposition = NEW_FOREGROUND_TAB;
} else {
// For existing browser, ensure its window is shown and activated.
- browser->window()->Show();
- // TODO(johnme): Can we sometimes be certain this was for a user gesture?
- browser->window()->Activate(false /* user_gesture */);
+ browser->window()->Show(user_gesture);
+ browser->window()->Activate(user_gesture);
}
extensions::LaunchType launch_type =
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/find_bar/find_bar_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698