Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents

Created:
5 years, 7 months ago by johnme
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jennb, jam, lcwu+watch_chromium.org, jianli, Dmitry Titov, yurys, jochen+watch_chromium.org, darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, android-webview-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add user_gesture param to WebContentsDelegate::ActivateContents This will be used for https://codereview.chromium.org/1135693006 Depends on: - https://codereview.chromium.org/1153793003 BUG=470830, 489256, 411702

Patch Set 1 : Add parameter #

Patch Set 2 : Update callers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -35 lines) Patch
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/cast_window_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/android/cast_window_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/guest_view/browser/guest_view_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
johnme
Note to reviewers: I've split up adding the parameter into the 1st patch set and ...
5 years, 7 months ago (2015-05-22 16:42:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153813003/20001
5 years, 7 months ago (2015-05-22 17:34:14 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-22 17:34:18 UTC) #6
johnme
On 2015/05/22 17:34:18, I haz the power - commit-bot wrote: > No LGTM from a ...
5 years, 7 months ago (2015-05-22 18:29:14 UTC) #7
Avi (use Gerrit)
5 years, 7 months ago (2015-05-22 21:30:13 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698